API V2 #194
Merged
API V2 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More specifically creates a single endpoint at PUT api/v2/election that doesn't currently do anything, but the routes are all there for more easily fleshing out #178
lprichar
requested review from
AddressXception,
keithrfung and
SteveMaier-IRT
|
This pull request introduces 3 alerts when merging 6e30a2d into cbc7cc5 - view on LGTM.com new alerts:
|
keithrfung
requested changes
Jan 5, 2022
|
This pull request introduces 3 alerts when merging ee0bceb into cbc7cc5 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Starts #178
Description
This begins a V1.1 of the API in support of #178. It doesn't actually add anything of value yet other than a create election endpoint that doesn't do anything, but adding substantial V1.1 endpoints will be substantially easier after this work.
Testing
Try
PUT /api/v1.1/electionwith{ "name": "Hamilton General Election" }. It should return back a 200 with a success message, but it doesn't actually do anything just yet.