Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing coal plates into the compressor resets the compressor. #490

Closed
ivangouba opened this issue Jul 13, 2016 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@ivangouba
Copy link

ivangouba commented Jul 13, 2016

I have a setup where I have a macerator that is connected with EnderIO pipes to a compressor, which is connected with EnderIO pipes to another compressor to make diamonds. The problem is that each time a coal plate is introduced into the last compressor (the one that turns coal plates into diamonds), it starts the process again.
2016-07-13_20 04 40

P.D. Using itemducts from Thermal Foundation doesn't produce the issue.

@cm0x4D cm0x4D added the bug label Jul 13, 2016
@cm0x4D cm0x4D self-assigned this Jul 25, 2016
@cm0x4D
Copy link
Member

cm0x4D commented Jul 25, 2016

Can you check if you have the same behavior if feeding the coal plates manually to the compressor, because this actually works for me...

cm0x4D pushed a commit that referenced this issue Jul 25, 2016
@cm0x4D
Copy link
Member

cm0x4D commented Jul 25, 2016

There are two ways to change an inventory slot content count:

  • Increment the existing itemstack count
  • Replace the existing itemstack with a new one with the same item type, but a different size

EnderIO seems to do the second, while adding items in the UI does the first. In the EA code we checked if the stack remains the same (object reference) and if not, the process is restarted. I changed the code to restart the process only if the actual type of item changes.

See #500. Still some testing and reviewing needed, but essentially the issue is fixed.

@ivangouba
Copy link
Author

Yes, probably that is the problem, because adding them by hand also works fibe for me.

cm0x4D added a commit that referenced this issue Aug 3, 2016
@cm0x4D
Copy link
Member

cm0x4D commented Aug 3, 2016

Fixed in develop

@cm0x4D cm0x4D closed this as completed Aug 3, 2016
cm0x4D pushed a commit that referenced this issue Aug 3, 2016
@metc metc added this to the 1.12.0 milestone Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants