Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows runtime binary loading crash #6

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Fix Windows runtime binary loading crash #6

merged 7 commits into from
Jul 14, 2023

Conversation

Scrappers-glitch
Copy link
Member

This PR modifies the snaploader-examples to test thread wait for Windows.

@Scrappers-glitch Scrappers-glitch added enhancement New feature or request examples Stressful testing the functionalities labels Jul 13, 2023
@Scrappers-glitch
Copy link
Member Author

Notice these key points that were affecting the Windows build:

  • Zip uses "/" only, Windows file separator will result in a null pointer exception in the zip entries.
  • Loading binaries need to be synchronized with the extraction process.

@Scrappers-glitch Scrappers-glitch changed the title Test thread wait on windows Fix Windows runtime binary loading crash Jul 14, 2023
@Scrappers-glitch Scrappers-glitch merged commit 91085a9 into master Jul 14, 2023
5 checks passed
@Scrappers-glitch Scrappers-glitch deleted the test-threadwait-windows branch July 14, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request examples Stressful testing the functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Scrappers-glitch