-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NativeBufferAllocator: release memory when buffer object is GCed #67
Conversation
…r object is garbage collected.
Hi @Scrappers-glitch, this PR is designed based on the JME LWJGL 3 buffer allocator, I am not sure I can follow the approach illustrated on issue #66 as I do not understand it fully. Please feel free to close this PR if you prefer a different implementation. Thanks |
No problem, I will try to continue on this PR and add the intended design. |
…*, jobject*)` to return mem-address
…avoid duplicated actions
…into fix-memory-leak
jme3-alloc/src/main/java/com/jme3/alloc/gc/GarbageCollectibleBuffers.java
Outdated
Show resolved
Hide resolved
jme3-alloc/src/main/java/com/jme3/alloc/gc/GarbageCollectibleBuffers.java
Outdated
Show resolved
Hide resolved
jme3-alloc/src/main/java/com/jme3/alloc/gc/MemoryScavenger.java
Outdated
Show resolved
Hide resolved
jme3-alloc/src/main/java/com/jme3/alloc/NativeBufferAllocator.java
Outdated
Show resolved
Hide resolved
jme3-alloc/src/main/java/com/jme3/alloc/gc/GarbageCollectibleBuffers.java
Outdated
Show resolved
Hide resolved
jme3-alloc/src/main/java/com/jme3/alloc/gc/GarbageCollectibleBuffer.java
Show resolved
Hide resolved
jme3-alloc/src/main/java/com/jme3/alloc/gc/GarbageCollectibleBuffers.java
Outdated
Show resolved
Hide resolved
@Ali-RS I would like to release the gamma version and the final stable version during this week, so please, could you help me by adding the examples you suggested on forums at the |
I think we should not rush, there are still issues that need to be fixed. See: https://hub.jmonkeyengine.org/t/jme-alloc-project/46356/180?u=ali_rs |
@Ali-RS Thanks for your contributions, this PR will be merged for now, if you want to inquire about the API status don't hesitate to ping me on the forums or here on a new issue, Have a great day! |
Fix #66
There are 2 TODOs remaining to be fixed.