-
Notifications
You must be signed in to change notification settings - Fork 122
remove python2 and rename swig bindings #3291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Is it ready?
Looks like the build almost went through. We'll need to remove debian/python-elektra.install
and debian/libelektra4-python2.install
from the debian branch.
No, not ready yet. Forgot about the label.
Can you please do that? |
Sure, I'll do that when the PR is ready. |
Thank you for the PR! ❇️ |
@mpranj there are some files to be removed in the debian branch, can you do it? (directly push there) |
@markus2330 yes, I thought I would remove it when this PR is ready rather than immediately. EDIT: files removed. |
jenkins build libelektra please |
For removing earlier is easier, then the builds of the PR go through. For adding or renaming is better afterwards, as it would break master. |
from my short tests:
|
jenkins build libelektra please |
Seems like I broke builds with 5122b28. I resolved the merge conflict such that we can merge this PR sooner. |
Thank you |
Thank you for maintaining the bindings and for the cleanup! |
Fixes #3186
lets see if this still builds...