Skip to content
This repository has been archived by the owner on Feb 16, 2025. It is now read-only.

remove python2 and rename swig bindings #3291

Merged
merged 5 commits into from
Nov 29, 2019

Conversation

manuelm
Copy link
Contributor

@manuelm manuelm commented Nov 27, 2019

Fixes #3186

lets see if this still builds...

Copy link
Member

@mpranj mpranj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Is it ready?

Looks like the build almost went through. We'll need to remove debian/python-elektra.install and debian/libelektra4-python2.install from the debian branch.

@manuelm
Copy link
Contributor Author

manuelm commented Nov 27, 2019

Thank you for the PR! Is it ready?

No, not ready yet. Forgot about the label.

Looks like the build almost went through. We'll need to remove debian/python-elektra.install and debian/libelektra4-python2.install from the debian branch.

Can you please do that?

@mpranj
Copy link
Member

mpranj commented Nov 27, 2019

Can you please do that?

Sure, I'll do that when the PR is ready.

@markus2330
Copy link
Contributor

Thank you for the PR! ❇️

@markus2330
Copy link
Contributor

@mpranj there are some files to be removed in the debian branch, can you do it? (directly push there)

@mpranj
Copy link
Member

mpranj commented Nov 27, 2019

@markus2330 yes, I thought I would remove it when this PR is ready rather than immediately.

EDIT: files removed.

@markus2330
Copy link
Contributor

jenkins build libelektra please

@markus2330
Copy link
Contributor

@markus2330 yes, I thought I would remove it when this PR is ready rather than immediately.

For removing earlier is easier, then the builds of the PR go through. For adding or renaming is better afterwards, as it would break master.

@manuelm
Copy link
Contributor Author

manuelm commented Nov 27, 2019

from my short tests:

cmake /...
[...]
-- Include Binding python
-- Include Binding lua
-- Exclude Binding ruby because explicitly excluded
[...]
cmake -DSWIG_EXECUTABLE= /...
[...]
-- Search for swig2 instead
-- Exclude Binding python because neither swig2/3 found. Please install swig3.0 and set -DSWIG_EXECUTABLE=
-- Exclude Binding lua because neither swig2/3 found. Please install swig3.0 and set -DSWIG_EXECUTABLE=
-- Exclude Binding ruby because explicitly excluded
[...]
cmake -DBINDINGS="MAINTAINED;-EXPERIMENTAL;-DEPRECATED;-ruby;-lua" /...
[...]
-- Include Binding python
-- Exclude Binding lua because explicitly excluded
-- Exclude Binding ruby because explicitly excluded
[...]

@markus2330
Copy link
Contributor

jenkins build libelektra please

@mpranj mpranj mentioned this pull request Nov 28, 2019
16 tasks
mpranj added a commit to mpranj/libelektra that referenced this pull request Nov 28, 2019
@mpranj
Copy link
Member

mpranj commented Nov 28, 2019

@manuelm can you please rebase to fix the conflict? Its not urgent. I don't know if 5122b28 fixes the problems on Jenkins.

@mpranj
Copy link
Member

mpranj commented Nov 28, 2019

Seems like I broke builds with 5122b28. I resolved the merge conflict such that we can merge this PR sooner.

@manuelm
Copy link
Contributor Author

manuelm commented Nov 28, 2019

Thank you

@mpranj mpranj merged commit 4d345d6 into ElektraInitiative:master Nov 29, 2019
@mpranj
Copy link
Member

mpranj commented Nov 29, 2019

Thank you for maintaining the bindings and for the cleanup!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename binding swig_python to python
3 participants