Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Docu #3475

Merged
merged 7 commits into from
Sep 15, 2020
Merged

Docu #3475

merged 7 commits into from
Sep 15, 2020

Conversation

markus2330
Copy link
Contributor

See #3472

Basics

These points need to be fulfilled for every PR:

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy.
  • The PR is rebased with current master.

If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

If you are already Elektra developer:

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and you also
    say that everything is ready to be merged.

@markus2330 markus2330 force-pushed the docu branch 2 times, most recently from ed8123e to 3b29699 Compare September 2, 2020 17:54
Copy link
Member

@mpranj mpranj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you for always updating the docs!

@@ -93,6 +108,14 @@ Please start by reading [here](/.github/CONTRIBUTING.md).
and GPL-incompatible libraries. If you compile Elektra, e.g., with GPL plugins, the
result is GPL.

## Which version should I use?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mpranj mpranj merged commit 70f450c into master Sep 15, 2020
@markus2330 markus2330 deleted the docu branch September 15, 2020 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants