Set new target name for so files (#3486)

[tmakar]

Basics

• Short descriptions of your changes are in the release notes
  (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
  Please always add them to the release notes.
• Details of what you changed are in commit messages
  (first line should have module: short statement syntax)
• References to issues, e.g. close #X, are in the commit messages.
• The buildservers are happy. If not, fix in this order:
  • add a line in doc/news/_preparation_next_release.md
  • reformat the code with scripts/dev/reformat-all
  • make all unit tests pass
  • fix all memleaks
  • fix the CI itself (or rebase if already fixed)
• The PR is rebased with current master.

Checklist

• I added unit tests for my code
• I fully described what my PR does in the documentation
  (not in the PR description)
• I fixed all affected documentation (see Documentation Guidelines)
• I fixed all affected decisions (see Decision Process)
• I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
• I updated all meta data (e.g. README.md of plugins and METADATA.ini)
• I mentioned every code not directly written by me in reuse syntax

Review

• Documentation is introductory, concise, good to read and describes everything what the PR does
• Examples are well chosen and understandable
• Code is conforming to our Coding Guidelines
• APIs are conforming to our Design Guidelines
• Code is consistent to our Design Decisions

Labels

• Add the "work in progress" label if you do not want the PR to be reviewed yet.
• Add the "ready to merge" label if everything is done and no further pushes are planned by you.

[kodebach]

Not sure using the PREFIX property is the best idea...

From the tests I also noticed, you'll also have to adjust this code to include the -plugin-:

libelektra/src/libs/loader/dl.c

Lines 73 to 77 in e080a5c

	char * moduleName = elektraMalloc (sizeof ("libelektra-") + strlen (name) + sizeof (elektraPluginPostfix) + 1);
	strcpy (moduleName, "libelektra-");
	strcat (moduleName, name);
	strcat (moduleName, elektraPluginPostfix);

Also we should probably add a #TODO in LibAddPlugin.cmake that we should still switch to using -plugin- in CMake targets as well. It would be possible to have a libelektra-foo.so library output and a libelektra-plugin-foo.so plugin output. But we couldn't use our add_lib (foo ...) and add_plugin (foo ...) CMake functions for that, since both would try to create elektra-foo CMake targets.

[kodebach]

LGTM (assuming the CI is successful)

[kodebach]

@tmakar You'll also have to add the plugin- here ⬇️ to make the symlink for the default storage and resolver plugins work

libelektra/src/plugins/CMakeLists.txt

Lines 97 to 99 in bde5383

	create_lib_symlink (libelektra-${KDB_DEFAULT_STORAGE}.so libelektra-storage.so libelektra${SO_VERSION} PLUGIN)
	create_lib_symlink (libelektra-${KDB_DEFAULT_RESOLVER}.so libelektra-resolver.so libelektra${SO_VERSION} PLUGIN)

And you should probably search for all occurrences of libelektra-storage and libelektra-resolver in the whole repo and update those too.

[tmakar]

@kodebach Do you know where this elektra-spec in libelektra-plugin-elektra-spec.so comes from? 🤔 Shouldn't it just be libelektra-plugin-spec.so?

[tmakar]

@tmakar You'll also have to add the plugin- here arrow_down to make the symlink for the default storage and resolver plugins work

libelektra/src/plugins/CMakeLists.txt

Lines 97 to 99 in bde5383

	create_lib_symlink (libelektra-${KDB_DEFAULT_STORAGE}.so libelektra-storage.so libelektra${SO_VERSION} PLUGIN)
	create_lib_symlink (libelektra-${KDB_DEFAULT_RESOLVER}.so libelektra-resolver.so libelektra${SO_VERSION} PLUGIN)

And you should probably search for all occurrences of libelektra-storage and libelektra-resolver in the whole repo and update those too.

Thank you!!!!!!!

[tmakar]

@markus2330 can be merged!

[atmaxinger]

I think you should revert the changes to the old release notes, otherwise it looks good.

[atmaxinger]

jenkins build libelektra please

[atmaxinger]

jenkins build libelektra please

[tmakar]

jenkins build libelektra please

[tmakar]

jenkins build libelektra please

[tmakar]

jenkins build libelektra please

[tmakar]

jenkins build libelektra please

[tmakar]

jenkins build libelektra please

[tmakar]

@kodebach @atmaxinger @markus2330 can be merged.

[atmaxinger]

jenkins build libelektra please

[tmakar]

ready!

[tmakar]

@kodebach @atmaxinger @markus2330 you can merge this now 😉

[atmaxinger]

Amazing! 🚀