Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

lib: memory leak, fixes #4925 #4926

Merged
merged 1 commit into from
May 15, 2023
Merged

lib: memory leak, fixes #4925 #4926

merged 1 commit into from
May 15, 2023

Conversation

hannes99
Copy link
Contributor

@hannes99 hannes99 commented May 14, 2023

#4925

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

@hannes99 hannes99 requested a review from tmakar May 14, 2023 15:44
@hannes99 hannes99 changed the title lib: memory leak, fixes #4922 lib: memory leak, fixes #4925 May 15, 2023
Copy link
Contributor

@atmaxinger atmaxinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atmaxinger
Copy link
Contributor

Please add something to the release notes tho.

@hannes99 hannes99 force-pushed the memleak-4922 branch 2 times, most recently from d4f3e6e to f2f54f6 Compare May 15, 2023 15:52
@hannes99 hannes99 requested a review from markus2330 May 15, 2023 15:59
@atmaxinger atmaxinger merged commit af273eb into master May 15, 2023
@atmaxinger
Copy link
Contributor

Thank you for this fix!

@markus2330 markus2330 deleted the memleak-4922 branch May 18, 2023 05:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants