-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Improve c plugin (doc, tests, refactor) #4979
Conversation
- some small refactoring (e.g. remove unnecessary dups, reduce scope of variables) - add code documentation (Doxygen) - extended README.md - add unit tests
In what state is this? Do you think this should also be part of the v0.11 release? |
This PR is basically finished and ready for reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, yes, let us take this in. Shell recorder tests would have been nice.
So one use case is to extract a part of the KDB and copy the generated code | ||
to create the exported part of the KDB programmatically, e.g. for another Elektra installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one line per sentence according to documentation guidelines.
Co-authored-by: Markus Raab <markus2330@users.noreply.github.com>
Great work! |
jenkins build libelektra please |
2 similar comments
jenkins build libelektra please |
jenkins build libelektra please |
Basics
(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels