update to rust-elements 0.22.0 and rust-bitcoin 0.30.0 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
force-pushed
the
2023-06--bitcoin30
branch
2 times, most recently
from
445195c
to
2652770
Compare
Note that bitcoind-tests does not compile after this commit; it will be fixed in the next.
Ok, everything should compile now.
This specific lint took enough changes to fix that I gave it its own commit.
Ran clippy with --all-features to find these ones.
apoelstra
force-pushed
the
2023-06--bitcoin30
branch
from
2652770
to
6e34c57
Compare
Failing on errors should be done in CI, by setting -D warnings, say, rather than hardcoding these rules in the crate.
We haven't had a release in forever, let's do one.
apoelstra
force-pushed
the
2023-06--bitcoin30
branch
from
6e34c57
to
a94fa54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fair bit easier than the rust-elements upgrade, but still not entirely trivial.