Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove block from in-flight list when a duplicate is received #1085

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Remove block from in-flight list when a duplicate is received #1085

merged 1 commit into from
Feb 17, 2022

Conversation

psgreco
Copy link
Contributor

@psgreco psgreco commented Dec 27, 2021

Fixes: #1084

@psgreco psgreco requested a review from sipa as a code owner December 27, 2021 10:23
apoelstra
apoelstra approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5f96964

I don't fully understand this PR, but I checked that it won't cause any new deadlocks and that all the tests still passe.

@stevenroose
Copy link
Member

utACK 5f96964

@stevenroose
Copy link
Member

How come this is failing all CI?

@stevenroose stevenroose merged commit 24ab49d into ElementsProject:master Feb 17, 2022
@jhfrontz jhfrontz mentioned this pull request Mar 1, 2022
Closed
@psgreco psgreco deleted the master-blocktimeoutfix branch March 2, 2022 00:59
gwillen added a commit to gwillen/elements that referenced this pull request Apr 21, 2022
@gwillen
Merge 24ab49d into merged_master (Elements PR ElementsProject#1085)
5cfd381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sipa sipa Awaiting requested review from sipa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous "Timeout downloading block" when said block is received by submitblock
3 participants
@psgreco @stevenroose @apoelstra