Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements-qt: Fix arrows to increase/decrease Amount #1146

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

andreabonel
Copy link
Contributor

Fixes: #1144

The problem was that Elements uses different defaults for the "step" between coins and assets, but these defaults were ignored after calculation.

This PR just uses the right variable for the step calculation.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 38e9490 confirmed that this only touches qt stuff

@psgreco psgreco merged commit 0be72f4 into ElementsProject:master Aug 18, 2022
apoelstra added a commit that referenced this pull request Aug 18, 2022
…or rc4

85c25b1 Bump version to -rc4 (Pablo Greco)
bb684f2 Update manpages (Pablo Greco)
38e9490 Elements-qt: Fix arrows to increase/decrease Amount (Andrea Bonel)
5954b10 Fixing issuance cases and half blinded cases in PSET (Allen Piscitello)
707cf20 Fix tapscript comment (roconnor-blockstream)
7fb99ff Fix Icon position in dmg (Pablo Greco)

Pull request description:

  Backport #1140 #1141 #1145 and #1146  from master.
  Fix manpages
  Bump to -rc4

ACKs for top commit:
  delta1:
    utACK 85c25b1

Tree-SHA512: 78a30bec870530275d103b6cab630ebf96b2df39fd03fc426bb16b6743ce9311f7e7128e43bf7a6452d261377e6ac017d61b77cd9ad4e4c20040629ae20e13b4
@andreabonel andreabonel deleted the master_issue_1144 branch September 17, 2022 01:16
gwillen added a commit to gwillen/elements that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elements-qt: the arrows to increase/decrease the "Amount" don't work in the Send page
3 participants