RPC: Avoid assert by keeping a flag to identify trimmed dynafed blocks #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d block is incomplete and makes it crash
psgreco
force-pushed
the
master-fix-assert-trim-rpc
branch
from
cb41349 to
8f16e00
Compare
|
utack 8f16e00 |
delta1
approved these changes
Mar 17, 2023
| @@ -228,6 +230,13 @@ class CBlockIndex | |||
| return proof.value(); | |||
| } | |||
|
|
|||
| const bool dynafed_block() const { | |||
There was a problem hiding this comment.
Clang says
'const' type qualifier on return type has no effect
There was a problem hiding this comment.
yeah this warning has been annoying me, I thought it was fixed on the 22.x branch but it is not
There was a problem hiding this comment.
Thank you for posting this, but it has no effect on my RPI4 even though I have the latest version. On startup I get the same assert error. Any tips for me?
There was a problem hiding this comment.
If you see the assertion on startup, it usually means that you started IBD without trim_headers and then enabled trim_headers without finishing IBD, so the headers chain is much longer than the blocks. Either way, let's continue that conversation in #1240
delta1
added a commit
to delta1/elements
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes 2 crashes:
Fixes: #1224