various bugfixes for new fuzz test vectors #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an unsigned constant which we're bit-inverting, or'ing into a signed constant, then assigning back to the signed constant. We should make it explicit wth is going on here.
apoelstra
force-pushed
the
2025-02--fuzz-fixes
branch
from
ee34c9f to
0098f52
Compare
This originates in 8723deb which has no PR associated with it. We've really gotta stop putting thousands of unreviewed commits into this project and rebasing the history away..
Cherry-pick of bitcoin/bitcoin#24625 (1/2)
Cherry-pick of fa84a49 bitcoin/bitcoin#24625 (2/2)
apoelstra
force-pushed
the
2025-02--fuzz-fixes
branch
from
0098f52 to
371718b
Compare
Avoids a signed/unsigned integer conversion.
|
This doesn't have the backport of 23418 in it. |
delta1
added a commit
that referenced
this pull request
Feb 11, 2025
more fuzzer fixes (continuation of #1399)
delta1
added a commit
to delta1/elements
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly straightforward stuff in here, except that we needed to backport bitcoin/bitcoin#23418, which in turn required bitcoin/bitcoin#24625.
This does not fix the PSET RPC-related crash but it does fix various ubsan lints (and a couple actual crashes) for other parts of the codebase.