fix vector length calculation for targets in BlindTransaction #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
reviewed
Mar 15, 2019
| surjectionTargets.resize(tx.vin.size()*3); | ||
| targetAssetGenerators.resize(tx.vin.size()*3); | ||
|
|
||
| size_t maxTargets = tx.vin.size()*3; |
There was a problem hiding this comment.
Maybe note here that this is a strict upper-bound, and the size is likely less(and is shrunk later).
dgpv
force-pushed
the
fix-blindtransaction-target-array-size
branch
from
a8f5044 to
42a7a34
Compare
|
utACK 42a7a34 |
dgpv
force-pushed
the
fix-blindtransaction-target-array-size
branch
from
42a7a34 to
045335a
Compare
the size of surjectionTargets and targetAssetGenerator vectors was calculated as tx.vin.size()*3, based on the fact that for each input there might also be up to 2 issuance pseudo-inputs, but did not take into account that the number of auxiliary generators may exceed the number of inputs. This fixes the size calculations by taking into account auxiliary generators supplied beyond vin size.
|
Fixed mistype in comment: "The vectors will be srunk" -> "The vectors will be shrunk" |
|
utACK 045335a , spurious failure on one test, restarted. |
instagibbs
added a commit
that referenced
this pull request
Mar 28, 2019
…tion 045335a fix vector length calculation for targets in BlindTransaction (Dmitry Petukhov)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of surjectionTargets and targetAssetGenerator vectors was calculated as tx.vin.size()*3, based on the fact that for each input there might also be up to 2 issuance pseudo-inputs, but did not take into account that the number of auxiliary generators may exceed the number of inputs. This fixes the size calculations by taking into account auxiliary generators supplied beyond vin size.