configure option --enable-liquid for default liquidv1 chain #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
force-pushed
the
liquid_ifdef
branch
from
148b7d6
to
511c67d
Compare
|
build seems to work, needs to rebased after #573 is merged |
instagibbs
force-pushed
the
liquid_ifdef
branch
from
0a7de56
to
1fdc059
Compare
|
rebased. |
|
Had two functional tests fail, one in two separate builds not related to this PR(mysterious failure). I'm running these two tests in a spin-loop for a bit locally, and have restarted those builds. rare error with RPC port something something: #576 interface_bitcoin_cli: Can't replicate at all locally after hundreds of runs. |
|
Did you test the Gitian builds? @greenaddress Does this look good? |
instagibbs
force-pushed
the
liquid_ifdef
branch
from
e2041b5
to
88c256f
Compare
This was referenced Apr 17, 2019
instagibbs
force-pushed
the
liquid_ifdef
branch
from
554253e
to
f475780
Compare
instagibbs
added a commit
that referenced
this pull request
Apr 18, 2019
ff12bf7 QT: --enable-liquid needs to use different QAPP name for QSettings (Gregory Sanders) f475780 QT: WalletModel should always check for balance changes once (Gregory Sanders) 93e2660 QT: dummy address needs fully valid pubkey (Gregory Sanders) c227c65 QT: Cache the blinded destination values on transactions we create, like -cli (Gregory Sanders) 5622a83 QT: remove GetAmounts calls or put behind bitcoind mode only (Gregory Sanders) 17229bf QT: Add bracket to not reassign values on non-tx (Gregory Sanders) 88c256f Split out liquid gitian build descriptors (Gregory Sanders) 7bd0667 Change gitian defaults back to elements, leave commented out lines as switch (Gregory Sanders) 6d6ddc5 Rename binaries to liquid naming at end of gitian process (Gregory Sanders) aa2af38 --enable-liquid: liquid.conf and liquid.pid (Gregory Sanders) 3b1ca17 --enable-liquid: change default datadir to .liquid (Gregory Sanders) 1f67fec --enable-liquid for gitian builds (Gregory Sanders) 1fdc059 Add travis build for --enable-liquid (Gregory Sanders) 7eea59a configure option --enable-liquid for default liquidv1 chain (Gregory Sanders) Pull request description: The only behavior it modifies is that the default chain becomes `liquidv1`. Also added a Travis test for coverage and adapted a unit test, and enabled this mode for gitian descriptors. Tree-SHA512: 9a19267a51ee7a8906b6a8af9c511a4838ec529c5ea2873de215eb849111d2d2380679b524e7198f53606810b47cd85ef46a8fc5816c86e78ebedd8c30de0da7
This was referenced Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only behavior it modifies is that the default chain becomes
liquidv1. Also added a Travis test for coverage and adapted a unit test, and enabled this mode for gitian descriptors.