[rpc]blindrawtransaction accepts more commitments #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we re-give this ability it should be documented in the RPCs that use it. It was hidden functionality IIRC. |
|
@instagibbs Without this, people have to provide placeholder inputs before they can start blinding stuff, and people have to know which entries to replace. How is that better? |
|
Sorry I must have been unclear: please change the help to make it clear
this functionality exists.
…On Tue, Jul 9, 2019, 2:19 AM kallewoof ***@***.***> wrote:
@instagibbs <https://github.com/instagibbs> Without this, people have to
provide placeholder inputs before they can start blinding stuff, and people
have to know which entries to replace. How is that better?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#674?email_source=notifications&email_token=ABMAFU4VJWAHBXTC43SXQ5TP6QUXDA5CNFSM4H6XCFG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZPG6LY#issuecomment-509505327>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMAFU4PQFGSMDNO352OL7DP6QUXDANCNFSM4H6XCFGQ>
.
|
|
e.g., |
|
Oh, I misunderstood. Sorry about that. You are saying the |
|
Actually this is used in
I suppose this is technically correct but might want to make it even more explicit that this "final list" can include inputs not given in |
instagibbs
added a commit
that referenced
this pull request
Jul 23, 2019
d584b65 [test]decrese num of inputs on partial blind test (Akio Nakamura) 254b166 [rpc]blindrawtransaction accepts more commitments (Akio Nakamura) Pull request description: In #510 / #550 a requirement that the blinding commitments were equal in amount to the inputs was introduced. This requirement is correct for the final case, but not for partial transactions (e.g. where party 1 blinds their inputs before even handing the transaction over to party 2 to add theirs). In order to hide party 1's input amounts from party 2, blindrawtransaction must allow >= the inputs, since the commitments are shared beforehand (if not, the blinding fails; this may need further investigating). This PR restores the functionality to allow blinding commitments more than or equal to the amount of inputs, which makes the confidential assets demo https://github.com/ElementsProject/confidential-assets-demo functional again. Tree-SHA512: 11c7e1c648aea26be2f4cb47606cd8e9b40d9e0d736a7eeb1989d6fad10f8f06528fd90766cb95e304c9b2c371278b20d7ef61099cb8b6e18b281a260e5de92d
|
I'll touch up the help myself, ACK d584b65 |
|
@instagibbs Oh, I'm sorry to bother you. |
|
No worries I just don't want to hold up this improvement as is.
…On Tue, Jul 23, 2019, 8:58 PM Akio Nakamura ***@***.***> wrote:
@instagibbs <https://github.com/instagibbs> Oh, I'm sorry to bother you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#674?email_source=notifications&email_token=ABMAFU2HCXNICUGCYDNE3N3QA6SMVA5CNFSM4H6XCFG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2U275Q#issuecomment-514437110>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMAFUZOR5EJYZLJSHGYI4TQA6SMVANCNFSM4H6XCFGQ>
.
|
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 3, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 9, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 10, 2020
gwillen
pushed a commit
that referenced
this pull request
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #510 / #550 a requirement that the blinding commitments were equal in amount to the inputs was introduced. This requirement is correct for the final case, but not for partial transactions (e.g. where party 1 blinds their inputs before even handing the transaction over to party 2 to add theirs). In order to hide party 1's input amounts from party 2, blindrawtransaction must allow >= the inputs, since the commitments are shared beforehand (if not, the blinding fails; this may need further investigating).
This PR restores the functionality to allow blinding commitments more than or equal to the amount of inputs, which makes the confidential assets demo https://github.com/ElementsProject/confidential-assets-demo functional again.