Take mempool locks when doing compact block RPC calls touching mempool #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
added a commit
that referenced
this pull request
Oct 9, 2019
…ching mempool 67a669e Take mempool locks when doing compact block RPC calls touching mempool (Gregory Sanders) Pull request description: This may help reduce the failures in `feature_blocksign.py` that seem to occur fairly often. It could be that the mempool is in an inconsistent state, which messed up compact block finalization. Tree-SHA512: cd066933cf58b3c57869db3fd97c2de0ff554d442e91051f43626b12778d55835065ad5fc42fed09b7750796e9e0b2e6947f1ac54e02fe4c8e2a84fe340429ae
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 6, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 9, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 10, 2020
stevenroose
pushed a commit
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help reduce the failures in
feature_blocksign.pythat seem to occur fairly often. It could be that the mempool is in an inconsistent state, which messed up compact block finalization.