-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor dynafed improvements #958
Merged
stevenroose
merged 3 commits into
ElementsProject:master
from
stevenroose:fix-dyna-fedpeg
Mar 2, 2021
Merged
Some minor dynafed improvements #958
stevenroose
merged 3 commits into
ElementsProject:master
from
stevenroose:fix-dyna-fedpeg
Mar 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stevenroose
commented
Feb 10, 2021
- support blocksigners specifying their own activation to make coordination a bit more flexible
- don't force fedpeg script to change in order to change the block signing script
This allows the initial relaxed restriction on non-segwit fedpeg programs to be extended as long as the fedpeg program is not changed while the block signing parameters can be changed.
This should obviously only be done by blocksigners. The flag used is not documented.
apoelstra
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack fe03729
apoelstra
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utack 14a42a0
utACK, looks reasonable. |
stevenroose
added a commit
that referenced
this pull request
Mar 3, 2021
868e92f Add two missing dynafed fields to getblockchaininfo (Steven Roose) ae54a1b dynafed: Support changing mainnet dynafed activation (Steven Roose) 0f9b1a2 dynafed: Only verify proposed parameters if they differ from current (Steven Roose) Pull request description: Backport of #958. Tree-SHA512: d3f809e466b98f48ba76b8deacc1fc7516440089cd9146a94e9b53ef0dc20f9e53af88cc9edc507de6ccb2da74bf83ef3722f1ab81bb385e2b9a567a4d1f7e99
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Mar 26, 2021
Conflicts due to change of error state formatting upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.