Make it clear that the CRangeCheck is not called on explicit values #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is enforced by the `VerifyAmounts` method for regular transactions and by the `VerifyIssuanceAmounts` method for issuance values.
|
Let's await CI to see if I might have missed something, but I'm pretty confident that that assertion always holds. |
sanket1729
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
tACK a8a1a93.
Verified that all tests pass locally and checked that the only two calls for CRangeCheck are never called on explicit amounts.
Asserting this is safe and helpful.
|
utACK, although I'm not sure how much good review will do here -- if it tests ok, that seems like the real check. |
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is enforced by the
VerifyAmountsmethod for regular transactionsand by the
VerifyIssuanceAmountsmethod for issuance values.