channeld: send warning, not error if peer has old commitment number. #5152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This title of the PR is misleading, shouldn't it be exactly the opposite (ie |
rustyrussell
changed the title
instagibbs
suggested changes
Apr 7, 2022
| # l1 should NOT drop to chain, since it didn't receive an error. | ||
| time.sleep(5) | ||
| assert bitcoind.rpc.getrawmempool(False) == [] | ||
|
|
There was a problem hiding this comment.
Suggested change
| l1.daemon.wait_for_logs(["channeld WARNING: bad reestablish revocation_number: 0 vs 3"]) | |
cdecker
force-pushed
the
test-reestablish-fail
branch
from
3532d3d
to
9841485
Compare
|
Rebased on top of |
cdecker
force-pushed
the
test-reestablish-fail
branch
from
9841485
to
0697009
Compare
This is the minimal change to meet the desired outcome of lightning/bolts#934 which wants to give obsolete-db nodes a chance to fix things up, before we close the channel. We need to dance around a bit here, since we *will* close the channel if we receive an ERROR, so we suppress that. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker
force-pushed
the
test-reestablish-fail
branch
from
0697009
to
a551f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimal change to meet the desired outcome of lightning/bolts#934
which wants to give obsolete-db nodes a chance to fix things up, before we
close the channel.
We need to dance around a bit here, since we will close the channel if
we receive an ERROR, so we suppress that.