schema: add multifundchannel generation #7215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an edge case like MultifundchannelChannel_idsChannel_type was previously converted to MultifundchannelChannelIdschannelType instead of the correct MultifundchannelChannelIdsChannelType
Changelog-None
|
Oh yeah, those generated type names 🤦🏼♂️ I am hoping that at some point we move away from JSON schema as it doesn't really lend itself to composition and tends to define stuff in nested structures, which make this kind of name spacing necessary. I'd rather like to have a protobuf-like format where we start by defining small messages and then complex ones by composing them from the simpler ones. Then we could give meaningful names to these leave types as well. I'm sorry for all the pain that msggen has been 😅 |
cdecker
reviewed
Apr 14, 2024
cdecker
approved these changes
Apr 14, 2024
This was referenced Apr 16, 2024
|
Let's start merging so your stack doesn't grow too high :-) |
yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
FundChannelChannelTypeNameoverride for this aswell.This command actually was the only one with the following edge case when generating the camel case name for
MultifundchannelChannel_idsChannel_type. Since it splitted at_the camel case inidsChannelwas removed by.title(). So i changed theto_camel_casefunction to only uppercase the first character of a word and not implicitly lowercase all other letters.Fixes: #6193