Rust-bins: Upgrade tonic to v0.12 for v0.1.9 #7598
Conversation
nepet
changed the title
nepet
force-pushed
the
cln-rust-bins-v0.3_upgrade-tonic-version
branch
from
7c8844f
to
bf84b61
Compare
nepet
force-pushed
the
cln-rust-bins-v0.3_upgrade-tonic-version
branch
2 times, most recently
from
0820036
to
bdd9e33
Compare
|
This PR changed a bit now: We don't want to keep different branches for different minor versions of the rust crates for now, just update on
If you are ok with these changes @daywalker90, #7623 becomes obsolete. |
|
I'm fine with it, but i think @cdecker had concerns with upgrading dependencies when i made a PR for it. |
Yeah, I remember that upgrading some crate led to a lot of pain in the past, but I can't remember which crate it was. Upgrading tonic, on the other hand, brings some fixes that help us get better transport errors and is both wanted and needed by Greenlight, so this upgrade should be fine :) |
|
So, I could locally reproduce the error CI runs into. The error appears after we try to establish a connection with a certificate unknown to the I am going to invert the commit that upgrades tonic to |
nepet
force-pushed
the
cln-rust-bins-v0.3_upgrade-tonic-version
branch
from
bdd9e33
to
6a463f0
Compare
Tonic had some breaking changes since 0.8. We want to be closer to newer versions for downstream consumers to be able to benefit from changes in tonic. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
We bump the version to minor version 0.2 to allow ourselves to bump on patch level when we need to fix a bug or update a dependency. Changelog-Changed: Plugins: `cln-grpc` Upgrade tonic version and introduce new versioning scheme. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
nepet
force-pushed
the
cln-rust-bins-v0.3_upgrade-tonic-version
branch
from
6a463f0
to
2412fac
Compare
Upgrade tonic to v0.12 for rust bins v0.1.9
Description
This PR upgrades the tonic dependency of the rust libraries to v0.12. Latest version used was v0.8. Tonic had some major bugfixes in between these versions. We need to upgrade tonic for downstream consumers of our libs to be able to upgrade tonic as well.
This PR also introduces a new versioning scheme where we bump the minor semver version on any breaking api change such as the removal of deprecated calls as well as changes to the requirements of fields.
The whole rust lib stack cln-grpc cln-rpc cln-plugin and cln-grpc-plugin is now on v0.2.x, on top of tag cln v24.02.2 for the underlying message scheme.