cln-rpc: Make description field of Wait(any)invoiceResponse optional string

[laanwj]

cln-rpc: Make description field of Wait(any)invoiceResponse optional string

Description

In case of a bolt12 invoice, the description field is missing in waitinvoice and waitanyinvoice responses. Make it optional in the rust struct.

Related Issues

N/A afaik

Changes Made

• Bug Fix: Make description field of WaitanyinvoiceResponse an optional string.

Checklist

Ensure the following tasks are completed before submitting the PR:

• Changelog has been added in relevant commit/s.
• Tests have been added or updated to cover the changes: i don't know where to add it, there doesn't seem an existing test for this
• Documentation has been updated as needed: i don't think there is documentation for this struct
• Any relevant comments or TODOs have been addressed or removed.

Review note

Might want to be sure that this is the only response where this is needed? It looks like most invoice response structs have optional description, but not all:

• CreateinvoiceResponse
• SendinvoiceResponse

I don't think these have a possible BOLT12 path but not sure.

Also this is API breaking-I don't know how versioning is handled in the crate.

[laanwj]

Looks like the grpc mapping needs an analogous change.

[daywalker90]

These are auto-generated files you edited. The correct fix would be to fix the json schemas. I gave both waitinvoice and waitanyinvoice a quick look and they both require a description in the response. This was fine for bolt11 since invoice required a description. offer does not require a description so waitinvoice and waitanyinvoice schemas should remove description from it's required section.

[laanwj]

Ok, thanks, closing.