-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: ensure that we have jq, fail if it fails #7662
configure: ensure that we have jq, fail if it fails #7662
Conversation
Otherwise we can get other crashes it seems? Fixes: ElementsProject#7657 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have this check anyway, but looks like that it does not solve the problem? #7657 (comment)
ACK 91a2d03
Their file contents are incorrect, as detailed here: #7657 (comment). You can reproduce the corrupted file by uninstalling |
Anyway this PR is not checking for the jq version, IMHO this is not a fix for the bug, probably we want to check also the version? |
Nested within the loop, jq would fail silently. This can happen if jq is too old. Fixes: ElementsProject#7657 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
9d7f69d
to
1d3bdfb
Compare
This is strange, is not a rust error but looks like this is a new error: |
4578748
into
ElementsProject:master
Added as a requirement, but it's better to check than crash at runtime.
I also ensured that the build fails if JQ fails.
Fixes: #7657