pytests: extend the offline mode testcase #7675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
merged commit 02176f7
into
ElementsProject:master
36 of 38 checks passed
|
That was quick, I thought we would add code that fixes the test and extends a bit (disallowing manual connection attempts) |
Mh the PR was not ready? How do you want to extend it? |
Like this: #7676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline mode working properly?
Description
I discovered that a node even and specifically when started
--offlinemode still tries to acquire a listening socket (and would fail to start if it is already bound!)Also noteworthy, that an
--offlinenode can make outbound connections when done via CLI (or by a plugin like clboss or similar).What this PR does
Extend the testcase a bit and make it an
xfailfor the time being.What needs to be done
I think that an offline node needs to be really offline, because it may harm developers when trying to debug real world data 'in offline mode' and then a connection is made by mistake and a live network channel can end up in an invalid state.
This means that it should not try to bind a listening socket as well as forbid to make manual connections via cli, because a plugin that does not know the node is 'offline' can accidentally make a connection.