Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/headerversions.c: fix build without SQLite #7677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

whitslack
Copy link
Collaborator

Commit 5318459 broke the build without SQLite because this code:

new = tal_fmt(NULL, template,
              IF_SQLITE3(sqlite3_libversion_number()));

preprocesses into:

new = tal_fmt(NULL, template,
              );

which has a syntax error. Fix it by moving the comma into the macro argument.

Fixes: 5318459
Changelog-None

Important

Open for merging new PRs until the next PR freeze date is confirmed!

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

Commit 5318459 broke the build without
SQLite because this code:

	new = tal_fmt(NULL, template,
	              IF_SQLITE3(sqlite3_libversion_number()));

preprocesses into:

	new = tal_fmt(NULL, template,
	              );

which has a syntax error. Fix it by moving the comma into the macro
argument.

Fixes: 5318459
Changelog-None
gentoo-repo-qa-bot pushed a commit to gentoo-mirror/bitcoin that referenced this pull request Sep 18, 2024
gentoo-repo-qa-bot pushed a commit to gentoo-mirror/bitcoin that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant