#10 Make the <version> cli parameter optional #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elendev
requested changes
Oct 13, 2021
There was a problem hiding this comment.
Hello @LeJeanbono, thanks for your contribution (again)!
I have a small correction/suggestion, but otherwise it's all good for me!
Co-authored-by: Jonas Renaudot <jonas.renaudot@gmail.com>
Elendev
approved these changes
Oct 13, 2021
|
Thanks a lot @LeJeanbono ! |
|
Hum @LeJeanbono I just figured something out: it was not possible to bypass the version parameter since it wasn't optional. If you want to do an other PR to throw an error in case the version is not set it would be perfect, otherwise I'll create an issue 😄 . Cheers |
|
Oh you're right ! |
|
Here we are #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.