Reinforce PR #1288
Merged
Reinforce PR #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add reinforce leave one out - Add model weight sharing via pointers - Add online dataset
- Add example files - TODO: Add the whole online loop instructions once vllm fork is pushed
|
@Quentin-Anthony should be ready for a review 🙌 |
Quentin-Anthony
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Finally was able to finish reviewing and testing this! Merging into main. Thanks a ton @dmahan93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to test and get an example of how to orchestrate the online dataset + weight server