Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

139 characters missing from flex #160

Merged

Conversation

rfarley3
Copy link
Contributor

@rfarley3 rfarley3 commented Oct 3, 2020

Fixes #139 adds edges cases for start and end offsets to avoid missing start characters in FLEX messages.

Also include some changes that:

  • remove compiler warnings/type ambiguity when on Raspberry Pi architecture
  • refactors mw1 and len calculations into single place
  • centralize hardcoded sizes and offsets
  • handle long vs short address and single vs group decoding, particular as it pertains to:
    • changing the start and end offset of message content
    • decoding the capcode
    • decode the frag bit
  • refactors the message printing to encode printable whitespace modifiers so messages are printing on a single line, avoid empty messages, filter non-printables, convert % into literal (%%).

rfarley3 added 30 commits May 25, 2020 16:15
@EliasOenal
Copy link
Owner

Thanks a lot for the PR. I just have a small additional request: Given that this is a non-trivial change and contribution, would you mind adding your name (and optionally your email) to the source file? Establishing correct authorship and verifying the licensing is important to some distributions (e.g. Debian) and I would not want to cause issues in their packaging process.

@rfarley3
Copy link
Contributor Author

Can do, just saw this. I'm glad that this is useful.

@rfarley3
Copy link
Contributor Author

Authorship added

@rfarley3
Copy link
Contributor Author

Fixes #159

@EliasOenal EliasOenal merged commit e8dabd0 into EliasOenal:master Nov 2, 2020
@rfarley3 rfarley3 deleted the 139-characters-missing-from-flex branch February 7, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The first characters are missing from FLEX messages
2 participants