Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Icons / Mac #6

Closed
TwisterMc opened this issue Aug 6, 2019 · 8 comments
Closed

Missing Icons / Mac #6

TwisterMc opened this issue Aug 6, 2019 · 8 comments

Comments

@TwisterMc
Copy link

On the Mac, we're missing icons:

  • Tab Close
  • Find bar close
  • Right click extension icons (such as 1Password or uBar)

closebuttons
right-click

@vkhitrin
Copy link
Contributor

vkhitrin commented Aug 7, 2019

@TwisterMc,

On my side the tab close button is present:
Picutre
What version of firefox are you using?

But as you mentioned, find close button icon is not displayed

Menu items do not include any pictures due to the following CSS rule.
Unless there will be rules for each individual icon that can be present, in my opinion icons will look out of place as part of this theme, perhaps @EliverLara has a different approach.

@TwisterMc
Copy link
Author

I'm using FF 68.0.1 on the latest version of MacOS.

@vkhitrin
Copy link
Contributor

vkhitrin commented Aug 7, 2019

@TwisterMc

I use the same FF and macOS release.

Sorry, don't have a clue as of now on why you're encountering this.

@TwisterMc
Copy link
Author

The tab close button is missing because the SVG doesn't exist.
list-style-image: url("../icons/window-close-symbolic.svg") !important;
tabsbar.css line 152

There is no window-close-symbolic.svg in the repo.

There is a window-close-symbolic-light.svg though and if I switch line 152 to that, it works again.

@TwisterMc
Copy link
Author

For the right click icons, I can reverse the CSS rules in my userContent.css and will consider that one fixed. :)

@EliverLara
Copy link
Owner

Thanks for reporting! I have not faced this yet, I'll look into it

@pyrareae
Copy link

I have the same issue with the close buttons on firefox 70.0.1 on manjaro linux.

@Nano-Ocelot
Copy link

I have the same issue with the close buttons on firefox 70.0.1 on manjaro linux.

Also on Linux and am missing these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants