optional two spaces #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switched to using sed to preserve undo history |
|
Been using this for a while now, and it works great! |
specious
reviewed
Sep 29, 2017
autoload/elm.vim
Outdated
| @@ -62,6 +62,9 @@ fun! elm#Format() | |||
| let old_fileformat = &fileformat | |||
| call rename(l:tmpname, expand('%')) | |||
| silent edit! | |||
| if g:elm_format_two_spaces == 1 | |||
There was a problem hiding this comment.
I love this hack!
I actually added a --tabsize option to elm-format ( specious/elm-format@3d6aaff ) in part as a contribution to this quintessential discussion - avh4/elm-format#210
There was a problem hiding this comment.
That would be much preferable to using sed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally sometimes do not have the screen real estate for four spaces and prefer not to have to type backspace twice as many times as necessary, and I think you can read code perfectly fine with two spaces, so I modified my elm-vim to allow people to have two spaces instead of four...with this pr, everyone could have this option.
Also added instructions to automatically format code before saving, which I find extremely useful.