Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ethernet default config issue/type mismatch #9

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

TomSack
Copy link

@TomSack TomSack commented Sep 25, 2024

Fixes type mismatch when using the ETH_ESP32_EMAC_DEFAULT_CONFIG() macro.

Copy link

github-actions bot commented Sep 25, 2024

Warnings
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello TomSack, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 99e2ad3

Copy link
Collaborator

@dbahrdt dbahrdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das wurde in Commit espressif@e9df36a schon gefixt. Ich würde diesen daher per cherry-pick in diesen branch nehmen und den dann mergen. Das vereinfacht das Update auf die nächste Version.

@TomSack TomSack force-pushed the bugfix/ethernet_config_issue branch from d7600ba to 99e2ad3 Compare September 25, 2024 12:14
@TomSack
Copy link
Author

TomSack commented Sep 25, 2024

Das wurde in Commit espressif@e9df36a schon gefixt. Ich würde diesen daher per cherry-pick in diesen branch nehmen und den dann mergen. Das vereinfacht das Update auf die nächste Version.

Hab den Fix/commit von espressif reingenommen.

@TomSack TomSack merged commit 4576c0b into eltako/develop/5.3 Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants