cli: omit ANSI colors when not a TTY or NO_COLOR is set
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The colors used by `gsutil` are unreadable on my light-background color scheme, and `gsutil` does not respect either the [`NO_COLOR`] env var or being piped to a non-TTY stream. This patch makes it respect both. I looked for all matches of `git grep -P '(?<!cc)\.paint'`, which previously matched `ls`, `main`, `setmeta`, and `stat`, and now only matches the internals of the new `color` module. If there are other ways that ANSI codes are emitted, I may have missed them. Addresses EmbarkStudios#11. Arguably fixes it via the environment variable; an explicit command line option `--no-color` could still be added, which this patch makes easy. This uses the recently-stabilized [`IsTerminal`] trait, which bumps the MSRV to 1.70.0. [`IsTerminal`]: https://doc.rust-lang.org/std/io/trait.IsTerminal.html [`NO_COLOR`]: https://no-color.org wchargin-branch: no-color wchargin-source: e7b6232c54d34a1af61ebdd9a1e0a0eb31fe0324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colors used by
gsutilare unreadable on my light-background colorscheme, and
gsutildoes not respect either theNO_COLORenv var orbeing piped to a non-TTY stream. This patch makes it respect both.
I looked for all matches of
git grep -P '(?<!cc)\.paint', whichpreviously matched
ls,main,setmeta, andstat, and now onlymatches the internals of the new
colormodule. If there are other waysthat ANSI codes are emitted, I may have missed them.
Addresses #11. Arguably fixes it via the environment variable; an
explicit command line option
--no-colorcould still be added, whichthis patch makes easy.
This uses the recently-stabilized
IsTerminaltrait, which bumps theMSRV to 1.70.0.
wchargin-branch: no-color