Remove instant dependency when not building for web
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency was introduced originally in #112. It is a platform abstraction, but it is a tiny one and it is not harder to just use the std type which avoids always pulling in `instant` including for `wasm32-unknown-unknown` when not building for the web where it has no purpose at all. Want to have as few dependencies as possible on core low level crates like `puffin` that almost all of our code depends on.
|
We should also move away from using the |
|
Ah, I guess |
|
when one introduce a new dependency one need to run |
repi
commented
Sep 4, 2023
plasticbox
pushed a commit
to alt9github/puffin
that referenced
this pull request
Nov 9, 2023
) This dependency was introduced originally in EmbarkStudios#112. It is a platform abstraction, but it is a tiny one and it is not harder to just use the std type which avoids always pulling in `instant` including for `wasm32-unknown-unknown` when not building for the web where it has no purpose at all. Want to have as few dependencies as possible on core low level crates like `puffin` that almost all of our code depends on. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency was introduced originally in #112.
It is a platform abstraction, but it is a tiny one and it is not harder to just use the std type which avoids always pulling in
instantincluding forwasm32-unknown-unknownwhen not building for the web where it has no purpose at all.Want to have as few dependencies as possible on core low level crates like
puffinthat almost all of our code depends on.