Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linker/zombies: stop compilation after zombie errors. #950

Merged
merged 1 commit into from
Nov 30, 2022
Merged

linker/zombies: stop compilation after zombie errors. #950

merged 1 commit into from
Nov 30, 2022

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Nov 30, 2022

It's a bit silly to get spirv-val validation errors when we already decided compilation won't succeed.
(IIRC I did this in a context where this prevents other code from crashing due to invalid SPIR-V)

@eddyb eddyb merged commit 7a170d3 into EmbarkStudios:main Nov 30, 2022
@eddyb eddyb deleted the zombie-early-exit branch November 30, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants