Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce scalars (bool/int/float) as "native" SPIR-T types, consts and runtime ops. #50

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Introduce scalars (bool/int/float) as "native" SPIR-T types, consts and runtime ops. #50

wants to merge 4 commits into from

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Oct 23, 2023 •
edited
Loading

This is the first big step towards:

This is what the README.md example looks like now:

TODO: changelog (don't forget to mention the new switch! or should that be its own PR?), better docs, set up constant-folding (maybe even some OpSpecConstantOp support?).

@eddyb eddyb mentioned this pull request Oct 27, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 27, 2023
@eddyb
Combine TypeCtor/ConstCtor and "ctor args" into a single `TypeKin…
bccdf3f 
…d`/`ConstKind`. (#51)

The "constructor" idea was cute, but a mistake. At the end of the day
(see #1, #50, #29), the direction to move into is simpler and/or flatter
types and constants, *not* favoring the hierarchical ones.
@eddyb eddyb force-pushed the scalar branch 3 times, most recently from 4f48389 to a9049e6 Compare November 5, 2023 00:13
@eddyb eddyb mentioned this pull request Nov 5, 2023
Draft
@eddyb eddyb force-pushed the scalar branch 2 times, most recently from e4b6bc6 to f632e3c Compare November 8, 2023 05:38
@eddyb eddyb force-pushed the scalar branch 2 times, most recently from d24a607 to 5eefbcf Compare January 31, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eddyb