Fixup git operations #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently cargo, when cloning via git2, never sets a remote, so the logic for fetching updates basically never worked. I will add a test for this later... Shamelessly stolen from frewsxcv/rust-crates-index#129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues when dealing with git index repos managed by cargo that the internal testing in this crate didn't discover, namely that cargo (via git2) does not set remotes, and updating reflogs requires that a committer be set by gix which isn't the case in CI environments (I guess that doesn't apply if the remote is a directory on the same filesystem?). So this PR resolves both those issues.