This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Use Go embed.FS instead of external tool to embed assets #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasf
commented
Jul 11, 2021
|
|
||
| var fsys fs.FS = assetsFS | ||
| if f, err := fs.Sub(fsys, "ui/dist"); err != nil { | ||
| log.Error(fmt.Errorf("ui/dist does not exist in fs :%w", err)) |
There was a problem hiding this comment.
This will never execute as the program as specified now because go:embed ui/dist fill fail the compilation if it does not exist. Just error printing the error to be safe is something changes.
|
Awesome stuff, I will during this week look at why the actions runner keeps using 1.15.x instead of latest golang. |
suom1
approved these changes
Jul 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embed.FS is new i Go 1.16 so updated go.mod and ran go mod tidy as well.