This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
ui: avoid "async race" with new client POST #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getClients() and POST request were being issued one after another (not waiting for the POST to return). This can cause the GET /clients to return the old list before the user config is updated. Waiting for the POST to return before retrieving the new client list fixes the race. This behavior can be reproduced by adding a time.Sleep(time.Second) to the CreateClient server handler.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getClients() and POST request were being issued one after another
(not waiting for the POST to return). This can cause the GET /clients to
return the old list before the user config is updated. Waiting for the
POST to return before retrieving the new client list fixes the race.
This behavior can be reproduced by adding a time.Sleep(time.Second) to
the CreateClient server handler.
Not sure if there's supposed to be a .github/PULL_REQUEST_TEMPLATE.md; yes I read the code of conduct and contributor guide.