Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frame instead of visibleRect #2

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

rib
Copy link

@rib rib commented Dec 7, 2023

This backports an upstream macOS backend fix (rust-windowing#3043) that avoids referring to the visibleRect for knowing the new size of a view after a resize since that may have a spurious / invalid size. Instead winit checks the view's .frame() rectangle.

@rib rib requested a review from fornwall December 7, 2023 11:15
@fornwall fornwall merged commit 4e1a4a7 into ark-staging Dec 7, 2023
12 of 55 checks passed
@rib
Copy link
Author

rib commented Dec 8, 2023

just for reference here; I rebased and force pushed the ark-staging branch to avoid the merge commit while I prefer to have ark-staging just be a stack of rebased commits for when it comes to updating to later winit releases (will likely manage updates in terms of rebasing / cherry-picking any changes we need to keep for winit 0.29 as opposed to having a long-running branch where we merge master back in - otherwise it may get awkward to keep a clear view of our local changes that aren't upstream)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants