Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking error on FreeRTOS when using portYIELD_FROM_ISR #413

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Thom747
Copy link
Contributor

@Thom747 Thom747 commented Mar 5, 2024

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

The portYIELD_FROM_ISR() macro declares a variable called ulPortYieldRequired.
FreeRTOS assumes ulPortYieldRequired is in the global namespace.
To prevent linking errors, this PR introduces a function in the global namespace called ErpcPortYieldFromISR that then calls portYIELD_FROM_ISR().

To Reproduce

Build eRPC with FreeRTOS.

Expected behavior

eRPC builds as normal.

Desktop (please complete the following information):

  • OS: Ubuntu 20.04
  • eRPC Version: v1.12.0 and earlier

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

@Thom747 Thom747 force-pushed the fix-freertos-port branch from f35233b to 8fc7a47 Compare March 5, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant