Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playing Cards #179

Merged
merged 9 commits into from
Oct 6, 2023
Merged

Playing Cards #179

merged 9 commits into from
Oct 6, 2023

Conversation

harjitmoe
Copy link
Collaborator

Pertains to #107 but lacks trumps.

Based on existing images as much as possible, though the 9, 6 and clubs sign are modified to remain clearly distinct from the 8 and spades sign at such smaller sizes (compared to the keycap and suit-symbol emoji).

@Crissov
Copy link
Collaborator

Crissov commented Oct 6, 2023

Thank you for your contribution to this project! Sorry, this took so long to review. (I mostly check Github on my phone nowadays, but that’s unsuitable for a PR like this.)

I like the overall look of the cards.
I’m a bit confused about the design of the 10s differing from the other value cards, but am not opposed to it.

It’s a bit absurd but consequential to support skin tone selection in the face cards.
King 🤴 and Queen 👸 choices make absolute sense.
For Jack, Adult Person 🧑 or Man 👨 is okay I guess.
I think I would have gone with 💂 for the Knight/Cavalier instead of 🏇, but will accept it anyway.

Pips for face cards (K, Q, J and C) are of course Anglo-centric, but I don’t think there’re any accepted international symbols to use instead.

The trumps, which are not part of this PR, are complicated indeed, because mundane and arcane visualisations differ quite a lot. Unicode should figure this one out first, I guess.

@Crissov Crissov merged commit 9b35700 into EmojiTwo:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants