Tx builder max output size fixes #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users with many NFTs could run into problems creating certain txs that returned many of them as a change output as it would surpass the maximum output size limit in the ledger. The TxBuilder now takes this limit into account and errors if it is passed, and during the change output creation will attempt to spread out the NFTs over multiple outputs to not surpass the ledger limit. This is done as a greedy selection for now as the limit is currently 4kb or so and each asset is at most 64 bytes each so this should suffice.
TxBuilder: max output size + multiple change address support
…ut-size-fixes # Conflicts: # rust/src/tx_builder.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging of this PR: #187
Closes #159