Support cardano wallet style script creation #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add an empty function to confirm type signature [ch478] * feat: map the data types to rust types [ch478] * fix: we only need ScriptTemplate [ch478] * test: add native_scripts_json_util * feat: start parsing some json into ScriptTemplate * fix: move some functions around and ditch intermediary structure [ch478] * feat: make an address from String [ch478] * feat: use Bip32PublicKey [ch478] * feat: make a helper to recurse over the template [ch478] * feat: handle all and active_from [ch478] * feat: handle any and active_until [ch478] * fix: remove ScriptValidation enum [ch478] * fix: rename value to template * feat: implement cardano wallet style scripts * removes the temp enum * fixes the return type to be NativeScript * implements the some case * pass in an extra param for self * test: slightly better test * feat: pass cosigners HashMap by reference * feat: document the function and some param info * fix: did not need to map error * chore: explain what self_address is a bit more [ch478] * chore: commit flow doc [ch478] * Flesh out unit test + fix bugs Co-authored-by: rooooooooob <rooooooooob@users.noreply.github.com> (cherry picked from commit db03e27)
pedromtcosta
approved these changes
Nov 1, 2021
# Conflicts: # rust/src/utils.rs
vsubhuman
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cardano Wallet has its own multisig script style independent of CIP 29. This PR is meant to add support for this cardano-wallet specific DSL