NativeScript::hash() return changed to ScriptHash #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both Ed25519KeyHash and ScriptHash are 28-byte wrapper types with the same API (both generated by `impl_hash_type!()`) around a blake2b224 hash and are CBOR-equivalent, but are different semantically.
rooooooooob
commented
Oct 29, 2021
| @@ -1615,11 +1615,11 @@ pub enum ScriptHashNamespace { | |||
|
|
|||
| #[wasm_bindgen] | |||
| impl NativeScript { | |||
| pub fn hash(&self, namespace: ScriptHashNamespace) -> Ed25519KeyHash { | |||
| pub fn hash(&self, namespace: ScriptHashNamespace) -> ScriptHash { | |||
There was a problem hiding this comment.
I think in #127 when Ashish copied the hashing code from the key hashing method the wrapper type just wasn't changed to KeyHash. They're binary equivalent anyway both defined like:
impl_hash_type!(Ed25519KeyHash, 28);
impl_hash_type!(ScriptHash, 28);
rooooooooob
commented
Oct 29, 2021
|
|
||
| let script_hash = ScriptHash::from_bytes( |
There was a problem hiding this comment.
Although here we're doing the binary conversion explicitly in a test so it's weird that the type wouldn't have been changed to ScriptHash when writing that test.
vsubhuman
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both Ed25519KeyHash and ScriptHash are 28-byte wrapper types with the
same API (both generated by
impl_hash_type!()) around a blake2b224hash and are CBOR-equivalent, but are different semantically.