Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a test for new PrivateKey::from_bech32 function #245

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Added a test for new PrivateKey::from_bech32 function #245

merged 1 commit into from
Nov 3, 2021

Conversation

vsubhuman
Copy link
Contributor

Noticed too late that #244 is missing a test

@vsubhuman vsubhuman added the tests label Nov 3, 2021
@vsubhuman vsubhuman added this to the 10.0.0 milestone Nov 3, 2021
@vsubhuman
Copy link
Contributor Author

@rooooooooob , check when possible

rooooooooob
rooooooooob approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@rooooooooob rooooooooob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could add in the one from the doc string comment in the function but it should be fine. I got the code directly from js-chain-libs which is where PrivateKey came from originally anyway.

vsubhuman
vsubhuman commented Nov 3, 2021
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! /check

@vsubhuman vsubhuman merged commit 84e6f21 into master Nov 3, 2021
@vsubhuman vsubhuman deleted the ruslan/private-key-from-bech-test branch November 3, 2021 15:36
@vsubhuman vsubhuman mentioned this pull request Dec 7, 2021
Merged
@vsubhuman vsubhuman mentioned this pull request Feb 6, 2022
Merged
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rooooooooob rooooooooob rooooooooob approved these changes

@SebastienGllmt SebastienGllmt Awaiting requested review from SebastienGllmt

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vsubhuman @rooooooooob