Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing GH-checks to run the build properly + Fixing rand dependency wasm support #256

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Fixing GH-checks to run the build properly + Fixing rand dependency wasm support #256

merged 4 commits into from
Nov 9, 2021

Conversation

vsubhuman
Copy link
Contributor

No description provided.

@vsubhuman vsubhuman added this to the 10.0.0 milestone Nov 8, 2021
vsubhuman
vsubhuman commented Nov 8, 2021
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

vsubhuman
vsubhuman commented Nov 8, 2021
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

vsubhuman
vsubhuman commented Nov 8, 2021
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman changed the title Separated test and build gh action checks Fixing GH-checks to run the build properly and fail on exit statis Nov 8, 2021
@vsubhuman vsubhuman changed the title Fixing GH-checks to run the build properly and fail on exit statis Fixing GH-checks to run the build properly and fail on exit status Nov 8, 2021
@vsubhuman
Copy link
Contributor Author

vsubhuman commented Nov 8, 2021 •
edited
Loading

After adding the rand dependency in #232 the wasm build started failing with: error: the wasm32-unknown-unknown target is not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support

image

In this PR the gh-checks are fixed to properly run the builds and the build scripts are fixed to properly return the exit status so the checks can fail.

To fix the problem with the rand crate I have to add additional explicit dependency:

getrandom = { version = "0.2.3", features = ["js"] }

vsubhuman
vsubhuman commented Nov 8, 2021
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman changed the title Fixing GH-checks to run the build properly and fail on exit status Fixing GH-checks to run the build properly + Fixing rand dependency wasm support Nov 8, 2021
pedromtcosta
pedromtcosta approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@pedromtcosta pedromtcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested the build locally as well 👍

@vsubhuman vsubhuman merged commit a672056 into master Nov 9, 2021
@vsubhuman vsubhuman deleted the ruslan/split-test-and-build-checks branch November 9, 2021 13:59
@vsubhuman vsubhuman mentioned this pull request Feb 6, 2022
Merged
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedromtcosta pedromtcosta pedromtcosta approved these changes

@rooooooooob rooooooooob Awaiting requested review from rooooooooob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vsubhuman @pedromtcosta