Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize that this library is written in Rust #319

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Emphasize that this library is written in Rust #319

merged 1 commit into from
Jan 14, 2022

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Jan 10, 2022

Emphasize a bit more that this is a Rust library.
(For newbies like me who stumble across this library via web search).

@gavinharris-dev
Copy link

Would this be correct? Would be it more correct to say that it is a "Library written in Rust" as the 'WASM' build can also be utilised from JavaScript/TypeScript within both NodeJS and the Browser.

@rodrigc
Copy link
Contributor Author

rodrigc commented Jan 10, 2022

Sure, I'm open to rephrasing. My main intent is to try to boost this library in search engine results for Cardano Rust.
I brought this up on the dcSpark Discord: https://discord.com/channels/857911582972968981/881954687211933696/929906586900631592

@rodrigc
Copy link
Contributor Author

rodrigc commented Jan 10, 2022

I also brought up similar issues about web search for Cardano Rust on the IOG Discord: https://discord.com/channels/826816523368005654/894843835023228950/929914460754280528

@rooooooooob
Copy link
Contributor

As mentioned above, it's written using rust, but the vast, vast majority of people using this library are using the wasm or asm.js bindings for it. For searches, the readme does mention rust a bit below. I guess multiple references could help it though? The readme in general needs to be updated as it still mentions "haskell shelley" (to differentiate itself from the jormungandr shelley testnet in rust) even thuogh we've updated the library to work with Alonzo since then.

@rodrigc rodrigc changed the title Call this a "Rust library" Emphasize that this library is written in Rust Jan 11, 2022
@rodrigc
Copy link
Contributor Author

rodrigc commented Jan 11, 2022

OK, I changed to written in Rust.

@rodrigc
Copy link
Contributor Author

rodrigc commented Jan 11, 2022

I would suggest that:
used in Cardano's Haskell implementation of Shelley

to something like:

used in Cardano's implementation of Alonzo

or something similar.

@vsubhuman vsubhuman merged commit c1e7b72 into Emurgo:master Jan 14, 2022
@rodrigc
Copy link
Contributor Author

rodrigc commented Jan 14, 2022

Thanks for merging this. Is there a way to boost this library in this list: https://github.com/trending/rust ?

That way automated bots such as https://twitter.com/RustTrending will Tweet about this library.

@rodrigc rodrigc deleted the rodrigc/rust-readme branch January 14, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants