Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release / 10.1.0 #438

Merged
merged 1 commit into from
May 20, 2022
Merged

Release / 10.1.0 #438

merged 1 commit into from
May 20, 2022

Conversation

vsubhuman
Copy link
Contributor

@vsubhuman vsubhuman commented May 19, 2022 •
edited
Loading

@vsubhuman vsubhuman added this to the 10.1.0 milestone May 19, 2022
@vsubhuman vsubhuman requested a review from lisicky May 19, 2022 16:02
@vsubhuman vsubhuman self-assigned this May 19, 2022
@vsubhuman vsubhuman changed the title Version bump: 10.1.0 Release / 10.1.0 May 19, 2022
vsubhuman
vsubhuman commented May 20, 2022
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman
Copy link
Contributor Author

Release: https://github.com/Emurgo/cardano-serialization-lib/releases/tag/10.1.0

@vsubhuman vsubhuman marked this pull request as ready for review May 20, 2022 11:31
@vsubhuman
Copy link
Contributor Author

Published:

@vsubhuman vsubhuman merged commit 8eb8880 into master May 20, 2022
@vsubhuman vsubhuman deleted the release/10.1.0 branch May 20, 2022 11:42
@NicolasDP
Copy link
Contributor

since #436 is a breaking change you should have changed the major version and not the minor version:

MINOR version when you add functionality in a backwards compatible manner

https://semver.org

Now you are not forced to respect this. but then I am curious what version policy you follow ?

@vsubhuman
Copy link
Contributor Author

but then I am curious what version policy you follow ?

Mandatory major version change when JS API is breaking in a non-compatible way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisicky lisicky Awaiting requested review from lisicky

Assignees

@vsubhuman vsubhuman

Labels
release
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vsubhuman @NicolasDP